Open
Conversation
FelixAbrahamsson
force-pushed
the
seeded-random-sampler
branch
from
09494bb to
67c5077
Compare
samedii
reviewed
Mar 4, 2021
Contributor
samedii
left a comment
samedii
left a comment
There was a problem hiding this comment.
I guess this could be useful to have still and I was going to approve but it seems that the generator is changing the global random state which is probably not what we want? I am also not sure if the sampler is lazy when sampling or eager. We might want a for-loop that yields samples and switches the random state
This is still equivalent to a SequentialSampler on a shuffled dataset right so maybe there is a simpler alternative?
Contributor
|
Do we still think this is useful? Have you tried it out more @FelixAbrahamsson ? |
FelixAbrahamsson
force-pushed
the
master
branch
3 times, most recently
from
b49886f to
eebbf00
Compare
samedii
force-pushed
the
master
branch
3 times, most recently
from
c39f769 to
f93b796
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternatively we create a new sampler?